Fix false positive PropertyNotSetInConstructor for overridden and stubbed properties/classes #11636
+608
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmuffme
force-pushed
the
false-positive-property-not-set-in-constructor-for-stubbed-and-overriden
branch
from
2105bce to
3a760a7
Compare
…bbed properties/classes - Improve and deduplicate logic of previous PR vimeo#10817 - Fix vimeo#11261 - Fix vimeo#2319 - for stubbed classes, which generally do not contain any statements, assume that when calling parent::__construct(); all inherited, non-initialized properties are intialized. This assumption makes sense, since otherwise it would mean the stubbed class itself has PropertyNotSetInConstructor errors
…s to stubbed property types not reporting an error The actual error for vimeo#5194 was fixed in the meantime somewhere correctly already
Fix failing tests from github.com/vimeo/pull/11569
kkmuffme
force-pushed
the
false-positive-property-not-set-in-constructor-for-stubbed-and-overriden
branch
from
7439e1f to
31fc5d0
Compare
Contributor
Author
|
Failing tests are unrelated and added in #11569 (I fixed the "MissingConstructor" one, but the psalm/shepherd one I didn't know what you prefer there - ignore or fix it, but its out of scope) Also the failing Windows test (chunk 8) seems to be Windows specific - on Unix (as you can see) works fine and I don't have an option to reproduce it on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 4 false positives for
PropertyNotSetInConstructor