Skip to content

Conversation

@theodorejb
Copy link
Contributor

Also optimize ConfigFileTest slightly.

@weirdan
Copy link
Collaborator

weirdan commented Jan 28, 2024

Looks like yu need to target master instead.

@theodorejb theodorejb changed the base branch from 5.x to master January 28, 2024 22:26
@theodorejb theodorejb changed the title Add missing type declarations and default values to Context Remove unnecessary null type from initialized_methods Context property Jan 28, 2024
@theodorejb
Copy link
Contributor Author

@weirdan Thanks. The type declarations were already added to master, so this PR is much smaller now.

@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jan 28, 2024
@weirdan weirdan merged commit 275dfd8 into vimeo:master Jan 28, 2024
@weirdan
Copy link
Collaborator

weirdan commented Jan 28, 2024

Thanks!

@theodorejb theodorejb deleted the context-types branch January 28, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:internal The PR will be included in 'Internal changes' section of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants