Update master from 5.x #10597
Merged
Update master from 5.x #10597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ctions/cache-4
Unit test improvements for php-parser 5
Fix template replacement edge case
This change is for forward-compatibility with nikic/php-parser 5.0, where `InterpolatedStringPart` (née `EncapsedStringPart`) is no longer an expression. Thus we can't pass it to `NodeTypeProvider::getType()` anymore. Since that call returns `null` anyway, we can swap the condition order. Everything still works and Psalm type-checking is happy. This also might be a tiny performance improvement since it lets the common, cheap instanceof check come before a method call, but I haven't actually benchmarked it.
Baseline update
…order Switch condition order
Filtering is not necessary. Clients using LSP should filter the results themselves. That's what it says in the documentation. This reverts commit d6faff2.
weirdan
added
the
release:internal
Collaborator
|
Uhm, you sure you didn't make a mistake here with the destination branch? |
Collaborator
Author
|
I most definitely did. Fixed. |
orklah
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.