Merge pull request #8436 from TimWolla/attribute-target

Configure a correct attribute target in stubs/CoreGenericClasses.phpstub
vimeo · Aug 24, 2022 · 2fdcd5a · 2fdcd5a
2 parents 88d3382 + 3c2018a
commit 2fdcd5a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/stubs/CoreGenericClasses.phpstub b/stubs/CoreGenericClasses.phpstub
@@ -496,19 +496,19 @@ final class WeakMap implements ArrayAccess, Countable, IteratorAggregate, Traver
 }
 
 
-#[Attribute]
+#[Attribute(Attribute::TARGET_METHOD)]
 final class ReturnTypeWillChange
 {
     public function __construct() {}
 }
 
-#[Attribute]
+#[Attribute(Attribute::TARGET_PARAMETER)]
 final class SensitiveParameter
 {
     public function __construct() {}
 }
 
-#[Attribute]
+#[Attribute(Attribute::TARGET_CLASS)]
 final class AllowDynamicProperties
 {
     public function __construct() {}

diff --git a/tests/AttributeTest.php b/tests/AttributeTest.php
@@ -787,6 +787,22 @@ public function anotherMethod(): string
                 false,
                 '8.1',
             ],
+            'sensitiveParameterOnMethod' => [
+                '<?php
+
+                    namespace SensitiveParameter;
+
+                    use SensitiveParameter;
+
+                    class HelloWorld {
+                        #[SensitiveParameter]
+                        public function __construct(
+                            string $password
+                        ) {}
+                    }
+                ',
+                'error_message' => 'Attribute SensitiveParameter cannot be used on a method',
+            ],
         ];
     }
 }