Allow control over default branch #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 41 41
Lines 4508 4531 +23
===========================================
+ Hits 4508 4529 +21
- Misses 0 2 +2
Continue to review full report at Codecov.
|
1 task
r-ash
approved these changes
May 25, 2022
Contributor
r-ash
left a comment
r-ash
left a comment
There was a problem hiding this comment.
Looks good to me! Will leave open until we can see working on some deployed version
Comment on lines
+330
to
+337
| msg <- c("The 'master_only' field (used in", | ||
| sprintf("%s:remote:%s", filename, name), | ||
| "is deprecated and replaced with 'default_branch_only'", | ||
| "and will be dropped in a future version of", | ||
| "orderly. Please rename it in your orderly_config.yml") | ||
| orderly_warning(flow_text(msg)) | ||
| d$default_branch_only <- d$master_only | ||
| d$master_only <- NULL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by orderly.server to control a few hard-coded "master" places
Failure on windows is due to new version of openssl not being compiled yet...