VIMC-2929: Remove custom fields from main orderly table #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 41 41
Lines 4531 4524 -7
==========================================
- Hits 4529 4522 -7
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
Reviving this. This and vimc/orderly-web#476 have to be tested and deployed together |
Member
Author
|
The date on that PR offers some suggestions why it dropped out of view |
hillalex
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment 2020: This removes the last bit of the pre-proper-schema orderly db - adding custom fields to the report_version table. The schema version number increases (which triggers a db rebuild) but this should have minimal visibility to users.
This should be tested on uat with montagu pointing at this version to make sure nothing breaks.
Comment 2022: This has to be merged/deployed in lock step with vimc/orderly-web#476 (and waiting for OW master build to be fixed before that build can pass!) Then will need to rebuild
orderly.server.