Skip to content

Add posibility to set up cookies max-age in runtime #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2017

Conversation

DefteZ
Copy link
Contributor

@DefteZ DefteZ commented Aug 27, 2017

Now it is not flexible to have only two options for cookie max-age time:

  • session
  • persistent cookies (never expire)

It force developer to handle expirations for refresh token in cookies explicit
(if i get correctly expired refresh token handled by the same expired_token_loader decorator as access tokens, and there is not any special ad-hoc decorator for it ).

This change provide option for developer to define max-age in call time

@coveralls
Copy link

coveralls commented Aug 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b0f0f52 on DefteZ:max_age into 043ba23 on vimalloc:master.

@vimalloc
Copy link
Owner

Looks great. Thanks for contributing! 👍

@vimalloc vimalloc merged commit e41b6f7 into vimalloc:master Aug 27, 2017
@vimalloc
Copy link
Owner

I'll get a new release out later today with these changes. Thanks!

@DefteZ DefteZ deleted the max_age branch August 28, 2017 10:37
@vimalloc
Copy link
Owner

Sorry, this slipped my mind the other day. It is released as 3.3.0 now. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants