Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Update possible mypy return codes, update documentation #2317

Closed
wants to merge 4 commits into from
Closed

Update possible mypy return codes, update documentation #2317

wants to merge 4 commits into from

Conversation

everybodyeverybody
Copy link

@everybodyeverybody everybodyeverybody commented Jun 19, 2020

Added an extra section to the documentation which demonstrates how one
can install syntastic from git using vim packages.

mypy will return 2 as a potential error code in cases of improperly
formatted python syntax.

For example:

#!/usr/bin/env python
a =

will provide a return code of 2 for invalid syntax.

This updates the mypy configuration to accept this return code.

Added an extra section to the documentation which demonstrates how one
can install syntastic directly into vim version 8+ from git.

mypy can now return 2 as a potential error code in cases of improperly
formatted python syntax. For example:

```
a =
```

will provide a return code of 2. This updates the mypy configuration to
accept this return code.
@lcd047
Copy link
Collaborator

lcd047 commented Jun 19, 2020

Your patch does two unrelated things. First, it allows exit code 2 for mypy. This is undesirable because exit 2 corresponds to crash, bad arguments, and other non-standard conditions. Of these only syntax error produces a meaningful error message for syntastic to parse, meaning that with your patch conditions such as "No such file or directory" get silently ignored. You really do want to know about these.

Second, it adds an example of installing syntastic "directly into vim version 8+ from git". This is too restrictive to be useful, redundant since the main README already mentions :help packages, and struggles to get the Markdown syntax right.

Sorry, but no.

@lcd047 lcd047 closed this Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants