Skip to content

Add heredoc #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 6, 2020
Merged

Add heredoc #120

merged 14 commits into from
Mar 6, 2020

Conversation

mattn
Copy link
Member

@mattn mattn commented Jul 19, 2019

No description provided.

@mattn mattn changed the title [WIP] Add heredoc Add heredoc Jul 19, 2019
@mattn
Copy link
Member Author

mattn commented Jul 20, 2019

PTAL

@tyru
Copy link
Member

tyru commented Jul 20, 2019

🙌

@tyru
Copy link
Member

tyru commented Jul 21, 2019

@mattn please tell me if it's available to review 🙆‍♂

@tyru
Copy link
Member

tyru commented Jul 21, 2019

Current heredoc implementations may have more problems than we found.

vim-jp/issues#1294
vim/vim#4713

So we can skip heredoc support now, we should work on other issues.
(e.g. review & merge currently opening pull requests)

@tyru
Copy link
Member

tyru commented Mar 6, 2020

@mattn this can be merged if you fix conflict 👍

@tyru
Copy link
Member

tyru commented Mar 6, 2020

I forgot I have permission for this branch. fixed remaining vint errors.
I think this branch is mergeable. merge it

@tyru tyru merged commit c91b43a into master Mar 6, 2020
@tyru tyru deleted the heredoc branch March 6, 2020 11:24
@tyru tyru mentioned this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants