Skip to content

alloc profiler: avoid divide-by-zero errors #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2022
Merged

alloc profiler: avoid divide-by-zero errors #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8269aa4
fix whitespace
vilterp Jan 12, 2022
4daa624
avoid divide-by-zero errors when printing error message
vilterp Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions stdlib/Profile/src/Allocs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ A sample rate of 1.0 will record everything; 0.0 will record nothing.
"""
function start(; sample_rate::Real)
ccall(:jl_start_alloc_profile, Cvoid, (Cdouble,), Float64(sample_rate))

_g_sample_rate[] = sample_rate
_g_gc_num_before[] = Base.gc_num()
end
Expand Down Expand Up @@ -120,12 +120,15 @@ function fetch()
raw_results = ccall(:jl_fetch_alloc_profile, RawResults, ())
decoded_results = decode(raw_results)

missed_allocs = _g_expected_sampled_allocs[] - length(decoded_results.allocs)
missed_percentage = round(Int, missed_allocs / _g_expected_sampled_allocs[] * 100)
@warn("The allocation profiler is not fully implemented, and missed $(missed_percentage)% " *
"($(round(Int, missed_allocs)) / $(round(Int, _g_expected_sampled_allocs[]))) " *
"of allocs in the last run. " *
"For more info see https://github.com/JuliaLang/julia/issues/43688")
# avoid divide-by-0 errors
if _g_expected_sampled_allocs[] > 0
missed_allocs = _g_expected_sampled_allocs[] - length(decoded_results.allocs)
missed_percentage = round(Int, missed_allocs / _g_expected_sampled_allocs[] * 100)
@warn("The allocation profiler is not fully implemented, and missed $(missed_percentage)% " *
"($(round(Int, missed_allocs)) / $(round(Int, _g_expected_sampled_allocs[]))) " *
"of allocs in the last run. " *
"For more info see https://github.com/JuliaLang/julia/issues/43688")
end
return decoded_results
end

Expand Down