Add share doc and preview only open attachment warning

villers3 · Jul 20, 2022 · 10a0ae9 · 10a0ae9
1 parent 0221606
commit 10a0ae9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/src/cloud/components/Editor/index.tsx b/src/cloud/components/Editor/index.tsx
@@ -1050,6 +1050,9 @@ const Editor = ({
                   className='scroller'
                   getEmbed={getEmbed}
                   scrollerRef={previewRef}
+                  showLinkOpenWarning={
+                    !docIsEditable || !currentUserIsCoreMember
+                  }
                 />
               </StyledPreview>
             </StyledEditor>

diff --git a/src/cloud/components/MarkdownView/CustomizedMarkdownPreviewer.tsx b/src/cloud/components/MarkdownView/CustomizedMarkdownPreviewer.tsx
@@ -35,7 +35,7 @@ const CustomizedMarkdownPreviewer = ({
   getEmbed,
   scrollerRef,
   codeFence = true,
-  showLinkOpenWarning,
+  showLinkOpenWarning = false,
 }: CustomizedMarkdownViewProps) => {
   const { previewStyle } = usePreviewStyle()
   const { settings } = useSettings()

diff --git a/src/mobile/components/pages/DocViewPage.tsx b/src/mobile/components/pages/DocViewPage.tsx
@@ -142,6 +142,7 @@ const ViewPage = ({
                 onRender={onRender.current}
                 className='scroller'
                 scrollerRef={previewRef}
+                showLinkOpenWarning={true}
               />
             ) : (
               <>