Merge pull request #87 from vil02/assert_in_split_data_and_signature

style: remove `assert` from `split_data_and_signature`

puzzle_generator/encryption_algorithms/simple/common.py

@@ -28,7 +28,8 @@ def merge_data_and_signature(in_data: bytes, in_signature: bytes) -> bytes:
 def split_data_and_signature(
     in_bytes: bytes, signature_size: int
 ) -> typing.Tuple[bytes, bytes]:
-    assert len(in_bytes) >= signature_size  # nosec B101
+    if len(in_bytes) < signature_size:
+        raise ValueError("in_bytes is shorter than signature_size")
     data = in_bytes[:-signature_size]
     signature = in_bytes[-signature_size:]
     return data, signature

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "puzzle-generator"
-version = "0.12.0"
+version = "0.12.1"
 description = "Generates python code representing a puzzle"
 authors = ["piotr.idzik <vil02_puzzle_generator@10g.pl>"]
 readme = "./puzzle_generator/README.md"

tests/encryption_algorithms/test_common.py

@@ -8,3 +8,8 @@
 def test_digest_size(in_signature_params: dict[str, str]) -> None:
     some_hash = eac.sign_bytes(b"some_msg", b"some_key", in_signature_params)
     assert eac.digest_size(in_signature_params) == len(some_hash)
+
+
+def test_split_data_and_signature_raises():
+    with pytest.raises(ValueError, match="in_bytes is shorter than signature_size"):
+        eac.split_data_and_signature(b"0", 2)