Dark theme #3151
Description
Description
A lot users are asking for a dark theme for the docs.
I ain't categorically against it, but my concern is that it requires the duplication of all images. Most notably on the landing page.
Personally, I prefer light mode and I would always use light mode. Now if you go to https://vite.dev/ the landing page is always dark mode (it doesn't have a light mode) which I'd say breaks consistency with the docs pages (that have both light and dark mode).
I ain't categorically against dark mode, but I'm afraid that it'd slow us down non-negligibly. I think it's important we're able to move with fast development speed. For example, the landing page of vike.dev has changed dramatically and many times. I'm glad I didn't had to support two light modes for each landing page.
For the docs, the situation is less problematic because there are less illustrations, but there are still some. We'd need to replicate each illustration for each mode. For example: https://vike.dev/hooks#lifecycle => making it look nice for dark mode is non-negligible work. Since we're currently resources constrained, I'm inclined to focus on efficiency.
But I'm open for it and I understand that dark mode can be worth it. It's just that so far I'm inclined to prioritize other features which are objectively higher priority.
Plan
An option would be to have an escape hatch: pages which have complex illustrations can disable dark mode. So we could easily implement dark mode for the vast majority of docs page. As for the landing page I'd say let's add a dark mode for it only after the landing page is stable.