Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url encoding. #640

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix url encoding. #640

wants to merge 2 commits into from

Conversation

SEIAROTg
Copy link
Contributor

The tag "输入/输出" in https://vijos.org/d/dreamerjack_oj/p/1001 currently links to https://vijos.org/d/dreamerjack_oj/p/category/%E8%BE%93%E5%85%A5/%E8%BE%93%E5%87%BA (404: Not Found) as the slash wasn't encoded.

The tag "输入/输出" in https://vijos.org/d/dreamerjack_oj/p/1001 currently links to https://vijos.org/d/dreamerjack_oj/p/category/%E8%BE%93%E5%85%A5/%E8%BE%93%E5%87%BA (404: Not Found) as the slash wasn't encoded.
Copy link
Member

@moesoha moesoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moesoha moesoha self-requested a review May 8, 2023 09:26
Copy link
Member

@moesoha moesoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make segments be quoted twice (L377, url_for).

Seems this needs to be fixed in aiohttp (use _requote_path in url_for), not in vj4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants