detach child process

vijos · Sep 1, 2019 · acffc63 · acffc63
1 parent a4fc9de
commit acffc63
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/sandbox/sandbox.cc b/sandbox/sandbox.cc
@@ -21,11 +21,6 @@ Sandbox::Sandbox(const Options &options)
     : options_(options), host_stream_(&host_streambuf_) {}
 
 Sandbox::~Sandbox() {
-    // TODO(iceboy): when does nodejs destruct objects?
-    // TODO(iceboy): send terminate signal.
-    if (guest_pid_) {
-        waitpid(guest_pid_, nullptr, 0);
-    }
     if (host_socket_ != -1) {
         close(host_socket_);
     }
@@ -60,7 +55,7 @@ bool Sandbox::init() {
         return false;
     }
     close(guest_socket_);
-    guest_pid_ = pid;
+    waitpid(pid, nullptr, WNOHANG);
     return true;
 }
 

diff --git a/sandbox/sandbox.h b/sandbox/sandbox.h
@@ -47,7 +47,6 @@ class Sandbox {
     std::string root_dir_;
     int host_socket_ = -1;
     int guest_socket_ = -1;
-    pid_t guest_pid_ = 0;
     FdStreamBuf host_streambuf_;
     std::iostream host_stream_;
 };