Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a working custom judge implementation #57

Merged
merged 7 commits into from
Mar 20, 2018
Merged

a working custom judge implementation #57

merged 7 commits into from
Mar 20, 2018

Conversation

iceboy233
Copy link
Member

No description provided.

@iceboy233 iceboy233 requested a review from twd2 November 26, 2017 06:56
@twd2 twd2 mentioned this pull request Mar 10, 2018
@iceboy233
Copy link
Member Author

The problem was _POSIX_C_SOURCE not defined in judge.c, causing fdopen() to be undefined, and for some reason the calling convention does not match...

PROCESS_LIMIT),
wait_cgroup(judge_cgroup_sock,
judge_execute_task,
DEFAULT_TIME_NS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT_TIME_NS is too short for some cases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I think we need configurable time and memory limit for the custom judge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this configuration is global.

@twd2
Copy link
Member

twd2 commented Mar 19, 2018

Remark: interactive cases are not supported.

Copy link
Member

@twd2 twd2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#58

@twd2 twd2 merged commit 2cbafc9 into master Mar 20, 2018
@twd2 twd2 deleted the custom-judge branch March 20, 2018 02:47
@twd2 twd2 mentioned this pull request Mar 20, 2018
@undefined-moe
Copy link
Member

I wonder what's the data format for spj?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants