Pass flags to clang and fix POSIX non-compliance
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple ships a real c99 as written in the standard. Lots of flags don't work. Just stay with cc instead.
shenlebantongying
changed the title
clang and fix POSIX non-compliance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just looking into the source code and found this mini rabbit hole.
The code was detecting only
gccand the flags were not passed toclang.However, surprisingly, those flags will be rejected with a mythical error message. It turns out the
c99executable as written in the standard only have a few flags. Apple, for whatever reason I don't want to know, ships a realc99executable for macOS that would reject those extra flags.So, stay with
ccwhen using gcc/clang and pass identical flags to both of them.