Cover case where two focus traps are transitioned between pages #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // When transitioning between pages using hash route state, | ||
| // this anchor is some times lost. Do not attempt to focus | ||
| // on a non-existent anchor. | ||
| if (this.state.anchor != null && 'focus' in this.state.anchor) { |
There was a problem hiding this comment.
should this be a strict equality check? just poking at it
There was a problem hiding this comment.
Actually yes. If this value happens to be 0, or whatever, it'll throw an exception. Probably never going to happen, but I have no faith in that sort of thing anymore.
There was a problem hiding this comment.
Thoughts on: if (typeof this.state.anchor === 'object' && 'focus' in this.state.anchor)?
There was a problem hiding this comment.
Really, what we need is something like this.state.anchor instanceof ActualDOMElement
|
Ah, this is a good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit an issue transitioning between two pages with focus traps in IE10 using hash location history. For some reason, focus is lost when the hash url changes (I think. It's kind of a mess to debug)
The real moral of the story is: don't use window#hash for URLs, but in any case this PR fixes the problem.