Skip to content
This repository was archived by the owner on Jul 22, 2022. It is now read-only.

Downgrade sprockets #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Downgrade sprockets #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ gem 'jquery-rails'
gem 'turbolinks'
gem 'sqlite3', group: :development
gem 'pg', group: :production # For heroku
gem 'sprockets', '2.11.0'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could just be a requirement for test and development?

10 changes: 7 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ GEM
mime-types (2.4.3)
mini_portile (0.6.2)
minitest (5.5.1)
multi_json (1.10.1)
multi_json (1.11.1)
nokogiri (1.6.6.2)
mini_portile (~> 0.6.0)
pg (0.18.1)
rack (1.6.0)
rack (1.6.4)
rack-test (0.6.3)
rack (>= 1.0)
rails (4.2.0)
Expand Down Expand Up @@ -102,7 +102,7 @@ GEM
sprockets (>= 2.8, < 4.0)
sprockets-rails (>= 2.0, < 4.0)
tilt (~> 1.1)
sprockets (2.12.3)
sprockets (2.11.0)
hike (~> 1.2)
multi_json (~> 1.0)
rack (~> 1.0)
Expand Down Expand Up @@ -132,6 +132,10 @@ DEPENDENCIES
pg
rails (= 4.2.0)
sass-rails (~> 5.0)
sprockets (= 2.11.0)
sqlite3
turbolinks
uglifier (>= 1.3.0)

BUNDLED WITH
1.10.5
15 changes: 14 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,25 @@ Clone the repository
git clone https://github.com/greypants/gulp-rails-pipeline.git
```

Enter into the directory and run bundle install
Enter into the directory and run bundle install.
```
cd gulp-rails-pipeline
bundle install
```

If you are on mac you may be required to run the following to [install PostgreSQL libraries successfully](http://stackoverflow.com/a/28206009/1376627).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't include PostgreSQL as a dependency here... this bit might be distracting/confusing to anyone not using it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I'm not sure why I had to install it in this way or why I needed the pg gem. Could be a mac thing. I'll look into it further and update it accordingly.

Maybe the readme should say something like run bundle install --without production for those who don't have postgresql installed?


ARCHFLAGS="-arch x86_64" bundle install

It is required to update sprockets to use an older `2.x` version to remove `self.js` from loaded resources for
BrowserSync to work properly

bundle update sprockets

or for mac

ARCHFLAGS="-arch x86_64" bundle update sprockets

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this update, you wouldn't need to run these commands would you, unless you'd already bundled with a newer version right?

Install javascript dependencies. Once npm install runs, the `postinstall` setting in `package.json` will run `gulp build` and do an initial build of your assets.
```
npm install
Expand Down