Skip to content

Conversation

@nolway
Copy link

@nolway nolway commented Oct 7, 2025

Description

Use a generic in TrackList to provide better typing for _tracks.

Specific Changes proposed

The TrackList type has changed, I added a generic to provide stronger typing for the kind of track it stores.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Use a generic in TrackList to provide better typing for _tracks.
@welcome
Copy link

welcome bot commented Oct 7, 2025

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@FR073N
Copy link

FR073N commented Oct 7, 2025

I came across the same problem, this fix seems to be the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants