Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for running tests with Karma #714

Closed
wants to merge 8 commits into from
Closed

Added support for running tests with Karma #714

wants to merge 8 commits into from

Conversation

jrw95
Copy link
Contributor

@jrw95 jrw95 commented Aug 31, 2013

No description provided.

@heff
Copy link
Member

heff commented Aug 31, 2013

Nice. This will be great to have. Has it been working pretty consistently for you?

@jrw95
Copy link
Contributor Author

jrw95 commented Aug 31, 2013

Apurva and I tested this quite a bit during Brightcove Hack Week (it was our project for that week).
I actually haven't been doing much testing in video.js core lately, but I gave this a good going-over while preparing the pull request yesterday. The support we've added is pretty straightforward and well-documented, so it should be pretty easy to set up and use.

@heff
Copy link
Member

heff commented Sep 17, 2013

Working for me, and it's awesome to see.

The addition to .gitignore doesn't seem to be working for me. It's still letting me commit changes to the template file. Is the template supposed to work like the sandbox/.example files, and could we reuse that naming for this? e.g. test.conf.js.example

@jrw95
moved karma's conf.js to the sandbox directory (so changes to it shou…
28cbdd8 
…ld be ignored by git)

renamed the conf.js to karma.conf.js
removed test-template.conf.js from .gitignore
updated the CONTRIBUTING.md to reference karma.conf.js

testing:
ran the QUnit tests with these changes; no errors or failure to run tests
@jrw95
renamed karma.conf.js to karma.conf.example
d8c9f6d 
updated the CONTRIBUTING.md to refer to karma.conf.example, copying this file to karma.conf.js
@jrw95
missed the 'js' in the example file name
868e0ce 
updated CONTRIBUTING.md to reflect it
@jrw95
Copy link
Contributor Author

jrw95 commented Sep 18, 2013

I think this is done (finally!). I decided to stick with karma.conf.js.example (why didn't I think of putting this in sandbox to begin with?), because it more clearly identifies what this file is used for.

@heff
Copy link
Member

heff commented Sep 18, 2013

Haha, well, I'm thinking it should probably go under test/ or at the root. Sorry. :)

@jrw95
Copy link
Contributor Author

jrw95 commented Sep 18, 2013

I think sandbox is a good place to put the template because:

  1. The other example files are all grouped there.
  2. If/when a customer decides to try out Karma, they can do so in the same way as they would for the index.*.example pages, without the worry of git picking up their configuration file experiments.

@jrw95
changed the location of the karma.conf.js.example from sandbox to test
f37f390 
changed references to the file location in .gitignore and CONTRIBUTING.md and Gruntfile

testing:
verified that the .example file is picked up by git status and add (per this commit)
verified that any conf.js files are ignored if they are in the test/ folder
verified that with the new location of the karma.conf.js file in Gruntfile, that the tests run as expected
@heff heff closed this in 13dbf23 Sep 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrw95 @heff