fix: do not seek to live on first manual seek when autoplaying a live stream #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
force-pushed
the
fix/live-autoplay
branch
from
9b48cb3 to
a5b4b04
Compare
gkatsev
approved these changes
Jun 20, 2019
gkatsev
pushed a commit
that referenced
this pull request
Jun 20, 2019
…e stream (#6062) Before listening for the play/timeupdate combination when starting the LiveTracker, check if the player has already started playback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses an issue where autoplay players playing live streams would seek to the live edge after the first seek a user initiated (via UI or API).
Specific Changes proposed
Before listening for the
play/timeupdatecombination when starting theLiveTracker, check if the player has already started playback.Requirements Checklist
editors=1000#0))