Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce write method to handle value output #6021

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

davekiss
Copy link
Contributor

Description

I found myself needing to access the value that was being written to the time tooltip and the only way to do this was to overwrite the entire update method just to set the time content to the TimeTooltip state. This method would allow for overriding a single line of code if the DOM mutations aren't preferred.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

I found myself needing to access the value that was being written to the time tooltip and the only way to do this was to overwrite the entire `update` method just to set the `time` content to the TimeTooltip state. This method would allow for overriding a single line of code if the DOM mutations aren't preferred.
@gkatsev gkatsev added needs: LGTM Needs one or more additional approvals tested labels Jun 17, 2019
@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label Jun 18, 2019
@gkatsev gkatsev merged commit 204ff46 into videojs:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants