Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scottish Gaelic translation #5972

Merged
merged 2 commits into from
May 17, 2019
Merged

Add Scottish Gaelic translation #5972

merged 2 commits into from
May 17, 2019

Conversation

gunchleoc
Copy link
Contributor

Description

Add Scottish Gaelic translation.

I used an industry-standard tool for the translation and ran the result through https://jsonlint.com/, so the JSON should be complete and valid.

Specific Changes proposed

Add Scottish Gaelic translation

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Apr 30, 2019

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@mister-ben
Copy link
Contributor

The script that builds the lang files is choking on this file for some reason. Is it UTF-8?

@gunchleoc
Copy link
Contributor Author

This is why Travis rocks!

I have done a copy/paste into the de.json and resaved, that will hopefully ensure the correct file format.

Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gkatsev gkatsev added confirmed minor This PR can be added to a minor release. It should not be added to a patch release. labels May 17, 2019
@gkatsev gkatsev merged commit fc21475 into videojs:master May 17, 2019
@welcome
Copy link

welcome bot commented May 17, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@gunchleoc
Copy link
Contributor Author

Thanks for merging! :)

Is there any way I can be notified of when I need to update my translation? I work on too many translations to watch all the repositories completely ;)

@mister-ben
Copy link
Contributor

We try to keep this doc up to date https://github.com/videojs/video.js/blob/master/docs/translations-needed.md. Do you have any ideas how other projects manage notifying translators and what works well?

@gunchleoc
Copy link
Contributor Author

gunchleoc commented May 24, 2019

Usually translations are put on a translation platform for projects that have advanced. You could try https://hosted.weblate.org/ which is FLOSS and supports the JSON format. You can then push and pull - see documentation at https://docs.weblate.org/en/latest/admin/continuous.html

Translators can then watch their projects over there and get e-mails into their inboxes too if they want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants