docs: emphasize src object and video-js element #5960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
approved these changes
Apr 25, 2019
OwenEdwards
reviewed
Apr 25, 2019
docs/guides/player-workflows.md
Outdated
| @@ -306,14 +306,16 @@ var myPlayer = videojs('some-player-id'); | |||
| myPlayer.src('http://www.example.com/path/to/video.mp4'); | |||
| ``` | |||
|
|
|||
| When a string is provided as the source, Video.js will try to infer the video type from the file extension, but this iferrence will not work in all cases. It is recommended that the source is provided as an object including the type, as below. | |||
There was a problem hiding this comment.
... but this inference will not work ...
OwenEdwards
reviewed
Apr 25, 2019
|
Thanks, fixed |
gkatsev
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Favours using a source object as the argument to
src()in the workflows doc, and adds<video-js>to the setup doc.