Fixes so that the source handler mixin adds the expected API after minification

[imbcmdth]

Issue:

In video.js, the withSourceHandlers mixin was getting all the names of the functions it used in the SourceHandlers (canHandleSource, handleSource, and dispose) mangled by Closure Compiler.

As a result, it worked only with native source handlers that were compiled together with video.js but not any source handler that was registered later.

In addition, the nativeSourceHandler property was also mangled which meant that any Techs not compiled with video.js would not be able to fall-back to their nativeSourceHandler as a last ditch attempt to play the source if no SourceHandler was found that matched the type.

Finally, the tests were written expecting any SourceHandlers that were registered to use the same mangling as video.js instead of testing that the SourceHandler interface worked as expected.

Changes:

Source

• No longer explicitly export registerSourceHandler since it is properly mixed-in unmangled
• Mixin code now calls functions canHandleSource, dispose, and handleSource explicitly instead of by their mangled names
• A tech's nativeSourceHandler property is no longer mangled in the code and is called explicitly unmangled

Tests

• withSourceHandlers and registerSourceHandler are used explicitly instead of using the mangled names
• canHandleSource and handleSource are quoted to avoid mangling

[heff]

Wow, fun... Really glad we're moving away from GCC.

Should we just say source handlers is a 5.0 feature? If there continues to be updates to it it's gonna be a pain to change in two places.

Otherwise lgtm.

[imbcmdth]

@heff If you are asking whether or not this PR should be merged in, I think yes. It is simply fixing the SourceHandler API that was being destroyed by minification - there are not functional changes.

If you are asking whether we should consider source handlers an unsupported or beta features on vjs4, then I agree we shouldn't spend time adding or fixing them if any bugs or strange behaviors are discovered. Instead we should direct people wishing to write SHs to 5.

[gkatsev]

I'll be merging this in today unless there are objections. @heff?

[heff]

None from me.

[gkatsev]

Closed by d2de00c