Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore video tag attributes on tech change #1369

Closed
wants to merge 13 commits into from
Closed

Restore video tag attributes on tech change #1369

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4af8af0
add test for video tag attr conservation
dcharbonnier Jul 24, 2014
c4aa9fa
set attributes of video tag and not only values
dcharbonnier Jul 24, 2014
2537c98
add unsupported attribute to the video tag - test failing
dcharbonnier Jul 25, 2014
0e78c9e
helper to set attributes on an element from a map of values
dcharbonnier Jul 25, 2014
aeefefe
dummy compare of html content with a sort of the attributes
dcharbonnier Jul 25, 2014
dae47c6
ignore html attributes order for comparition
dcharbonnier Jul 25, 2014
998183f
save original tag attributes
dcharbonnier Jul 25, 2014
a443d21
restore original tag attributes n creation and overwrite if required …
dcharbonnier Jul 25, 2014
72bbabd
replace object.keys with vjs.obj.each for ie<9
dcharbonnier Jul 25, 2014
ca8313b
fix spacing
dcharbonnier Jul 25, 2014
b54f5e2
API consistency, getAttributeValues renamed to getElementAttributes
dcharbonnier Jul 25, 2014
1c5f928
clear variable naming
dcharbonnier Jul 25, 2014
0604746
move setElementAttributes close to getElementAttributes
dcharbonnier Jul 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix spacing
  • Loading branch information
@dcharbonnier
dcharbonnier committed Jul 25, 2014
commit ca8313bb83c082fcda3a35a15636eabc564fadb7
2 changes: 1 addition & 1 deletion src/js/media/html5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ vjs.Html5.prototype.createEl = function(){
var attr = attrs[i];
var attributes = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have attrs, attr, and attributes all in the same place now. We should see if that could be simplified or at least get more specific with the var naming.

if (typeof player.options_[attr] !== 'undefined') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're already checking for undefined in setElementAttributes, so could we simplify this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is for an overwrite of the tag initial values

<video autoplay></video>
videojs('',{autoplay:false});

we don't want to remove the autoplay if there is no autoplay defined on the player options I think. Please confirm.

attributes[attr]=player.options_[attr];
attributes[attr] = player.options_[attr];
}
vjs.setElementAttributes(el, attributes);
}
Expand Down