Added check and error message for undefined techs #1210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provides a more user friendly error when a tech listed in the `videojs.options` array isn't defined.
|
Awesome, thanks! The CI is reporting an error. Would you mind checking that out? |
This was causing the build to fail for some reason.
|
Ok, the CI looks like it's passing now. Apparently, it didn't like the way I formatted the white space. |
|
Pulled in, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a more user friendly error when a tech listed in the
videojs.optionsarray isn't defined. Definitely feel free to tweak the wording of the error message if you feel it can be clearer.