Skip to content

Menu title LI created outside UL #1107

Closed
@cmaish

Description

When videojs adds the menus, it seems that the .vjs-menu-title LI item that's created is added to the .vjs-menu (which is a DIV) instead of the .vjs-menu-content.

This is present for me in 4.4.3. This is present on the main page of http://www.videojs.com/ . The output HTML in my case is:

<div class="vjs-chapters-button vjs-menu-button vjs-control " role="button" aria-live="polite" tabindex="0" aria-haspopup="true" aria-label="Chapters Menu" style="display: none;">
   <div class="vjs-control-content"><span class="vjs-control-text">Chapters</span></div>
   <div class="vjs-menu">
      <ul class="vjs-menu-content"></ul>
      <li class="vjs-menu-title">Chapters</li>
   </div>
</div>

It seems that the culprit is:

https://github.com/videojs/video.js/blob/master/src/js/tracks.js#L951

which uses menu.el_ rather than menu.contentEl (or creates an LI rather than a div, not sure what the 'right' fix is here, but either should work).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions