Skip to content

Commit

Permalink
@heff turned on the custom html controls for touch devices. closes #1617
Browse files Browse the repository at this point in the history
  • Loading branch information
heff committed Oct 28, 2014
1 parent ce18a9a commit d552276
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ CHANGELOG
* @mmcc fixed an issue with the VolumeButton assuming it was vertical by default ([view](https://github.com/videojs/video.js/pull/1592))
* @DevGavin added a Simplified Chinese translation ([view](https://github.com/videojs/video.js/pull/1593))
* @heff Added the ability to set options for child components directly in the parent options ([view](https://github.com/videojs/video.js/pull/1599))
* @heff turned on the custom html controls for touch devices ([view](https://github.com/videojs/video.js/pull/1617))

--------------------

Expand Down
3 changes: 2 additions & 1 deletion src/js/media/html5.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ vjs.Html5 = vjs.MediaTechController.extend({
// Our goal should be to get the custom controls on mobile solid everywhere
// so we can remove this all together. Right now this will block custom
// controls on touch enabled laptops like the Chrome Pixel
if (vjs.TOUCH_ENABLED && player.options()['nativeControlsForTouch'] !== false) {
if (vjs.TOUCH_ENABLED && player.options()['nativeControlsForTouch'] === true) {
alert('useNativeControls');
this.useNativeControls();
}

Expand Down

0 comments on commit d552276

Please sign in to comment.