This repository was archived by the owner on Dec 10, 2020. It is now read-only.
Added FCSubscribe and proxy support #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertogasparin
force-pushed
the
feature/subscribe-proxy
branch
from
459a4ba to
924dabd
Compare
| @@ -463,6 +464,7 @@ package com.videojs.providers{ | |||
| switch(e.info.code){ | |||
| case "NetConnection.Connect.Success": | |||
| _model.broadcastEventExternally(ExternalEventName.ON_RTMP_CONNECT_SUCCESS); | |||
| _nc.call("FCSubscribe", null, _src.streamURL); // try to subscribe | |||
There was a problem hiding this comment.
would this cause any issues for normal playback like for mp4s?
There was a problem hiding this comment.
I've tested it with node-rtsp-rtmp-server, as it does not support FCSubscribe. VOD videos play fine: as the streaming server reports "unknown command" the swf code ignores it.
There was a problem hiding this comment.
I can second this. On-demand videos play fine when using the updated SWF.
|
This change is working for me too. Could you please review and merge? Thanks!! |
|
Bump. Can we get this sorted? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified version of this pull request.
Additionally, I've added the proxy parameter in order to properly support people behind firewalls.
I assume this might solve lots of complains about "rtmp stream not playing".
Should close issue #202
Tested with: