This repository was archived by the owner on Nov 13, 2022. It is now read-only.
Fix support for Atom 1.37 (and maybe a few older versions) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viddo
suggested changes
May 19, 2019
There was a problem hiding this comment.
Hi there!
Ouch, good catch! I guess I have not had to use my this in a while myself so had not noticed.
In addition to the inline suggestion (re: getMetricsReporter), can you remove the consumeMetricsReporter function and package.json entry? I think it's better if this plugin don't pollute their metrics with wrong data, and I don't think we're required to consume that service, right?
Thanks for the pull-request!
|
I must confess I fail to appreciate the ins and outs of these metrics... But you must be right, we can't do harm if we do nothing. So I added a noop proxy and cleaned things a bit following this change. Sorry for butchering the commit history. |
|
No worries, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently upgraded to Atom 1.37 (from 1.26) and it broke recent files finder.
The cause is a mandatory arg that has recently been added to the constructor of FuzzyFinderView you're extending: atom/fuzzy-finder@6fbfe35#diff-e0ee5d9b066d4ea2a281ddaf5be6993eR26
I looked into fuzzy-finder's code to see how it gets its
metricsReporterand it turns out it is a service it consumes. So I could replicate into this project and it fixed my error.I'm not too sure that my fix is semantically correct since I don't know anything about metricsReporter. And I'm not too strong on the Coffee side. But I'd really like recent files finder to continue working in recent Atoms, so here's a PR that you can at least use for reference.