Skip to content
This repository was archived by the owner on Nov 13, 2022. It is now read-only.

Make selection operations: select-next-item and confirm-selection work again #22

Merged
merged 4 commits into from
May 6, 2017

Conversation

forceuser
Copy link
Contributor

fix to match changes that happened in v1.5.1 of fuzzy-finder https://github.com/atom/fuzzy-finder/tree/v1.5.1

@viddo viddo merged commit 812b716 into viddo:master May 6, 2017
@viddo
Copy link
Owner

viddo commented May 6, 2017

@forceuser Thanks for the PR!

Also wanted to ask, considering the underlying implementation (atom-select-list) already setup the core bindings, are these custom commands really necessary? Unless I overlook something I believe the following kind of keymap would give you the same capabilities:

# keymap.cson
# change down and enter to your the keys you want to use:
'.recent-files-fuzzy-finder':
  'down': 'core:move-down'
  'enter': 'core:confirm'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants