#277 Move video rendering fully to ffmpeg and html #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move unneeded code and deps (bye, pygame)
…sh screen, sort out cookie issues
…ocess, fix overlay flag always true
…bly on pi. Improve ffmpeg logging
…raoke.sh launch script, deprecate unused args
…r, handle anonymous singers, add screensaver! No more iphone zoom on inputs
…30. Configurable screensaver timeout with -t
…URL override for custom networking setups.
|
doing great work! Got this up and running in wsl2! The big ah ha moment was firewall related on windows, and port forwarding. You'll need to open an incoming rule in windows firewall (i went with 8080 for no particular reason) Then for port forwarding I needed to run a command like this.
If you get remote video streaming working. This will replace my current setup for home karaoke. 😄 |
|
Hi, glad you’re checking this out, but not sure I understand your use case
here. What do you mean by “remote streaming” and what issues are you having?
With this I can host a PiKaraoke server on one machine, and open the splash
screen on another computer on the LAN and stream to it, which is what I
regard as remote streaming.
If you wanted to open the stream to the internet, you’d have to configure
your router to port forward to your LAN address and port running the
server. Note you’d probably have to forward both ports 5555 for the http
server and 5556 for the ffmpeg server
…On Sun, Dec 3, 2023 at 3:35 PM Deastrom ***@***.***> wrote:
doing great work! Got this up and running in wsl2!
The big ah ha moment was firewall related on windows, and port forwarding.
You'll need to open an incoming rule in windows firewall (i went with 8080
for no particular reason)
Then for port forwarding I needed to run a command like this.
netsh interface portproxy add v4tov4 listenport=8080 listenaddress=0.0.0.0
connectport=8080 connectaddress=<ip of wsl2 instance>
https://learn.microsoft.com/en-us/windows-server/networking/technologies/netsh/netsh-interface-portproxy
If you get remote video streaming working. This will replace my current
setup for home karaoke. 😄
—
Reply to this email directly, view it on GitHub
<#279 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7KXNW6MHX3CVBE3IIS55LYHUEFDAVCNFSM6AAAAAA7YOHTW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGYZTSMJWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Gave it a shot, no luck. I edited my netsh to forward both 5555 and 5556 to my wsl2. Then modified the windows firewall to allow 5555 tcp inbound and 5556 udp inbound. logs don't say much. i'm pretty happy to run it from a browser in wsl2 (since it supports gui on windows now). I'm having other ffmpeg errors too. I imagine it's the python and ffmpeg version i'm running python 3.12.0 here's my pip freeze ouput. if you have a specific version of python you're deving on, let me know. I just wanted to let you know this is great work I can create an issue if you like, but since this specific to this branch, i think the PR is an appropriate place ---edit---- |
|
I’m still a bit lost. Can you explain further what your setup is? I’m not
familiar with wsl2. In my testing, I have run a PiKaraoke server in
windows, raspberry pi, and osx and accessed it remotely with another
machine.
Example: raspberry pi host
./pikaraoke.sh —hide-splash
Launches the server on http://pikaraoke.local:5555 and does not open the
splash screen on the host server.
OSX splash screen client: open http://pikaraoke.local:5555/splash
iPhone user client. Open the QR code url shown on the splash screen. Queue
up songs, they play on the osx client.
…On Sun, Dec 3, 2023 at 5:32 PM Deastrom ***@***.***> wrote:
Gave it a shot, no luck.
[2023-12-03 19:27:32] INFO: Song starting: Blink-182 • All The Small Things (CC) 🎤 [Karaoke] [Instrumental Lyrics]
[2023-12-03 19:27:32] DEBUG: Stream is playing
[2023-12-03 19:27:33] INFO: Song ending: Blink-182 • All The Small Things (CC) 🎤 [Karaoke] [Instrumental Lyrics]
[2023-12-03 19:27:33] DEBUG: Killing ffmpeg process
logs don't say much. i'm pretty happy to run it from a browser in wsl2
(since it supports gui on windows now). I'm having other ffmpeg errors too.
I imagine it's the python and ffmpeg version i'm running
python 3.12.0
ffmpeg version n6.1
here's my pip freeze ouput. if you have a specific version of python
you're deving on, let me know. I just wanted to let you know this is great
work
annotated-types==0.6.0
attrs==23.1.0
autocommand==2.2.2
Babel==2.9.1
Brotli==1.1.0
certifi==2023.11.17
charset-normalizer==3.3.2
cheroot==10.0.0
CherryPy==18.8.0
click==8.1.7
ffmpeg-python==0.2.0
Flask==2.2.5
Flask-Babel==2.0.0
flask-paginate==2021.10.29
future==0.18.3
h11==0.14.0
idna==3.6
inflect==7.0.0
itsdangerous==2.1.2
jaraco.collections==4.3.0
jaraco.context==4.3.0
jaraco.functools==4.0.0
jaraco.text==3.12.0
Jinja2==3.0.3
MarkupSafe==2.1.3
more-itertools==10.1.0
mutagen==1.47.0
outcome==1.3.0.post0
portend==3.2.0
psutil==5.9.6
pycryptodomex==3.19.0
pydantic==2.5.2
pydantic_core==2.14.5
pypng==0.20220715.0
PySocks==1.7.1
pytz==2023.3.post1
qrcode==7.4.2
requests==2.31.0
selenium==4.15.2
setuptools==69.0.2
sniffio==1.3.0
sortedcontainers==2.4.0
tempora==5.5.0
trio==0.23.1
trio-websocket==0.11.1
typing_extensions==4.8.0
Unidecode==1.3.7
urllib3==2.1.0
websockets==12.0
Werkzeug==3.0.1
wsproto==1.2.0
yt-dlp==2023.11.16
zc.lockfile==3.0.post1
I can create an issue if you like, but since this specific to this branch,
i think the PR is an appropriate place
—
Reply to this email directly, view it on GitHub
<#279 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7KXNQ75JP7MK2UVDQPIGTYHUR4TAVCNFSM6AAAAAA7YOHTW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXG4YDCMZQGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
wsl2 is windows subsystem for linux. it's basically a baked in vm for linux things so i don't have to do weird conda things on windows 😛 |
|
Ah I see, well you're covering new territory here. I got this working on
Windows natively with python3 and virtual env, no other package managers
like conda necessary so you may want to try that. I haven't updated the
readme yet, but the installation should be: install the latest ffmpeg and
chrome, then run ./setup.bat (sets up venv and pulls requirements down to
the virtual env) then launch with ./pikaraoke.bat.
Now that I'm thinking this through, I do actually recall on the first
stream Windows popped up a security warning about allowing ffmpeg to stream
over port 5556, I hit the button to accept this server side and it didn't
bother me again. Maybe wsl2 is having issues with that piece.
…On Sun, Dec 3, 2023 at 6:39 PM Deastrom ***@***.***> wrote:
wsl2 is windows subsystem for linux. it's basically a baked in vm for
linux things so i don't have to do weird conda things on windows 😛
i'll keep trying previous versions of python see if that helps at all
—
Reply to this email directly, view it on GitHub
<#279 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7KXNWM7NP6LGZG6QAKKATYHUZUZAVCNFSM6AAAAAA7YOHTW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXG42DOOJSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
That would have been the firewall. Now the linux os i'm using in wsl2 is arch. I wonder if it'd get along better with ubuntu? Anyway, I could give just native windows a shot. |
…not working in some configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.