Add option to set initial search and delete delay values #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From testing 1000ms seems like a good delay. For me the API has not complained yet with 1000ms set for both. Perhaps you could change the default delay to 1000ms instead. |
|
After a bit more careful testing, search delay does not seem nearly as impactful as delete delay. Documentation and code has been updated accordingly. |
|
Just tested this for hours and it works perfectly. Also a delete delay value of 800ms works fine without triggering any rate-limits. Hoping this PR gets merged. |
exil0867
reviewed
Oct 24, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
victornpb
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128 and #118
This change is