"Ended because API returned an empty page" with 10K messages left

[Valcartier]

Undiscord Version

v5.2.0

Browser

111.0.5563.65 (Official Build) (64-bit)

Extension

TamperMonkey

Reproduction steps

1. I initially had around 76K messages in a DM to delete
2. I followed proper instructions, using TamperMonkey, and installed the script
3. I ran the script, and bulk deleted around 66K messages in the span of 2-3 days
4. This morning, I ran the script again with 10K messages remaining

Actual results

The actual result was that the window returned:

Fetching messages...
Grand total: 10565	(Messages in current page: 0	To be deleted: 0	Skipped: 0)	offset: 87
Ended because API returned an empty page.
[End condition A].	{"running":true,"delCount":0,"failCount":0,"grandTotal":10565,"offset":87,"iterations":5,"_seachResponse":{"total_results":10565,"messages":[],"analytics_id":"2c2bbd338e4da352bd5b5fce114bd10f"},"_messagesToDelete":[],"_skippedMessages":[]}

Expected results

I had expected the continuation of deletion

Bug affects

• DMs
• DMs (group)
• Channels
• Channel (NSFW)

Additional information & file uploads

None further

[kvere]

getting the same issue, undiscord currently broken

[Valcartier]

getting the same issue, undiscord currently broken

Ah damn. I thought it was an issue on just my end. Glad to know it's not just me

[victornpb]

It looks like the issue might be due to a recent Discord update. I haven't had a chance to investigate it yet, and unfortunately, I'm currently feeling sick, so I can't fix it right away. However, I'll do my best to find a solution over the weekend and let you guys know when it's resolved.

sorry and thanks for your understanding

[Valcartier]

It looks like the issue might be due to a recent Discord update. I haven't had a chance to investigate it yet, and unfortunately, I'm currently feeling sick, so I can't fix it right away. However, I'll do my best to find a solution over the weekend and let you guys know when it's resolved.

sorry and thanks for your understanding

Hey, no worries! Thanks for everything you've done; it's been really convenient. Take your time, rest up, and make sure it isn't anything bad like a fever.

Take care!

[sorryzzss]

It looks like the issue might be due to a recent Discord update. I haven't had a chance to investigate it yet, and unfortunately, I'm currently feeling sick, so I can't fix it right away. However, I'll do my best to find a solution over the weekend and let you guys know when it's resolved.

sorry and thanks for your understanding

Is there a discord server for this script?

[olstice]

It looks like the issue might be due to a recent Discord update. I haven't had a chance to investigate it yet, and unfortunately, I'm currently feeling sick, so I can't fix it right away. However, I'll do my best to find a solution over the weekend and let you guys know when it's resolved.

sorry and thanks for your understanding

How will we be informed that its been resolved?

[victornpb]

expect updates on this thread

this issue will get closed, when I have a solution, and a new version will be pushed to everyone

[olstice]

expect updates on this thread

this issue will get closed, when I have a solution, and a new version will be pushed to everyone

im sorry for making a duplicate! i really didnt know there was one already that you actually responded to

[PetrBlue]

Tried to use it after @hannahgrayson19 commented. Deleted 150+ messages, still going. Normally it would delete either 0 or 25 messages.

[victornpb]

Update

The search results are no longer up-to-date, this is a optimization on discord side, as it makes sense to let the database slowly reindex deleted messages instead of make it instantly reindex, it's known that removing stuff on historical databases is a resource expensive operation. Unfortunately this makes things a bit harder on Undiscord side. The good news is that I already had a plan to allow Undiscord to prefetch messages. It's a bit of a happy coincidence but I still have to finish it, so this will be a more long term solution https://github.com/victornpb/undiscord/compare/prefetch. This will be in v5.3.0.

---

For now, I just released v5.2.1
(Make sure to click the update button, or just click the GreasyFork button again on the home page.)

I increased the defaultSearch delay to 30s between pages.
Keep in mind this is a temporary workaround, and is not a complete fix, it still stops sometimes.