Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in Resume Checkpoint #57

Closed
chienyiwang opened this issue Aug 20, 2019 · 3 comments
Closed

Bugs in Resume Checkpoint #57

chienyiwang opened this issue Aug 20, 2019 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@chienyiwang
Copy link

Thanks for the great work on this template.
However, in the base_trainer.py, there are two bugs while resuming checkpoints:

  1. line 100: (I think this is related to i face error when resume training. #54, but you closed the issue without fixing it)
    While resume training from saved checkpoints, there will be "reference before assignment" error on the not_improved_count variable.
  2. line 165 and 171:
    The sanity check here is invalid, as the config would be overwritten by the config.json of the saved checkpoint when parsing config (line 22 in parse_config.py)
@victoresque victoresque added help wanted Extra attention is needed bug Something isn't working labels Aug 23, 2019
@SunQpark SunQpark self-assigned this Aug 24, 2019
@SunQpark
Copy link
Collaborator

Thank you for reporting these problems, @chienyiwang.
I'll start working on this soon.

SunQpark added a commit to SunQpark/pytorch-template that referenced this issue Aug 27, 2019
@SunQpark
Copy link
Collaborator

I made PR #58 for this Issue. Could you review the changes @chienyiwang??

@chienyiwang
Copy link
Author

Just reviewed. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants