DATA-4054 Data pipelines Typescript support #551
Conversation
| let dataSource = tabularDataSource; | ||
| if ( | ||
| useRecentData && | ||
| (!dataSource || dataSource.type === TabularDataSourceType.UNSPECIFIED) | ||
| ) { | ||
| dataSource = new TabularDataSource({ | ||
| type: TabularDataSourceType.HOT_STORAGE, | ||
| }); | ||
| } |
There was a problem hiding this comment.
@vijayvuyyuru in the context of DATA-4091 i think this is safe right? if dataSource was null before, we will still send null
There was a problem hiding this comment.
Im not 100% sure, I think if tabularDataSource is undefined, doing dataSource.type might cause an exception?
There was a problem hiding this comment.
If we're handling this in app, what's the reason behind adding it here?
There was a problem hiding this comment.
Im not 100% sure, I think if tabularDataSource is undefined, doing dataSource.type might cause an exception?
I think !dataSource || would short-circuit: Playground Link
If we're handling this in app, what's the reason behind adding it here?
I was thinking if we do this in SDKs, we essentially stop population of the useRecentData field, then we can drop it in App, then drop it in SDKs.
| let dataSource = tabularDataSource; | ||
| if ( | ||
| useRecentData && | ||
| (!dataSource || dataSource.type === TabularDataSourceType.UNSPECIFIED) | ||
| ) { | ||
| dataSource = new TabularDataSource({ | ||
| type: TabularDataSourceType.HOT_STORAGE, | ||
| }); | ||
| } |
There was a problem hiding this comment.
If we're handling this in app, what's the reason behind adding it here?
| * | ||
| * @returns A page of data pipeline runs | ||
| */ | ||
| async nextPage(): Promise<ListDataPipelineRunsPage> { |
This PR:
Manual testing: See https://gist.github.com/n0nick/52bb4954472e618d302bd20a350712b9