Prevent streams from throwing timeout errors #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b9c6c09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I haven't had a chance to look too deeply yet, but what would happen now if a stream fails to connect? |
|
Do we still need this? |
DTCurrie
approved these changes
Sep 9, 2025
|
Would probably still be a good idea to do, I'll think through the failed to connect logic one more time to make sure we can still handle that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After peeking into
getStreamI found that there are some design elements that I don't like. It sets a timeout that will in some cases throw an error based on a non-configurable stream timeout. This can cause complications or issues if a component mounts and unmounts quickly in succession, and I think this is probably best left for userland behavior, so I'm switching to just using theaddmethod for thecreateStreamClienthook.