DATA-4318: Upping API and Adding Dataset_ids #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etai-shuchatowitz
requested review from
gabegottlob,
lia-viam,
tahiyasalam and
njooma
|
@etai-shuchatowitz try pulling from main and trying again please :) |
etai-shuchatowitz
force-pushed
the
DATA-4318/add-dataset-ids-to-upload
branch
from
f5d78fb to
a1aab33
Compare
|
Ah, that did it! Thank you very much! |
njooma
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://viam.atlassian.net/browse/DATA-4318
We need to add the newly added dataset_ids parameter to the SDKs.
EDIT: I'm seeing that tests are failing because it's not looking at the correct API version. Am I supposed to commit the generated proto files?