Skip to content

Update some mappings to dicts for ease of updates #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ typecheck:
_buf: clean
rm -rf src/viam/gen
chmod +x plugin/main.py
pip install protoletariat mypy-protobuf
poetry install
$(eval API_VERSION := $(shell grep 'API_VERSION' src/viam/version_metadata.py | awk -F '"' '{print $$2}'))
buf generate buf.build/viamrobotics/api:${API_VERSION}
buf generate buf.build/viamrobotics/goutils
pip install protoletariat mypy-protobuf
poetry install
protol -e googl* --in-place -s _grpc.py -s _pb2.py -s _pb2.pyi -o src/viam/gen buf buf.build/viamrobotics/api
protol -e googl* --in-place -s _grpc.py -s _pb2.py -s _pb2.pyi -o src/viam/gen buf buf.build/viamrobotics/goutils
find src/viam/gen -type d -exec touch {}/__init__.py \;
Expand Down
6 changes: 3 additions & 3 deletions src/viam/app/app_client.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import json
from datetime import datetime
from enum import Enum
from typing import Any, AsyncIterator, List, Literal, Mapping, Optional, Tuple, Union
from typing import Any, AsyncIterator, Dict, List, Literal, Mapping, Optional, Tuple, Union

from grpclib.client import Channel
from typing_extensions import Self
Expand Down Expand Up @@ -205,9 +205,9 @@ def from_proto(cls, robot_part: RobotPartPB) -> Self:
secret: str
robot: str
location_id: str
robot_config: Optional[Mapping[str, Any]]
robot_config: Optional[Dict[str, Any]]
last_access: Optional[datetime]
user_supplied_info: Optional[Mapping[str, Any]]
user_supplied_info: Optional[Dict[str, Any]]
main_part: bool
fqdn: str
local_fqdn: str
Expand Down
Loading