-
Notifications
You must be signed in to change notification settings - Fork 56
DOCS-2902: Edit machine management api from QA #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
npentrel
merged 15 commits into
viamrobotics:main
from
sguequierre:DOCS-2902/machine-management-api-qa
Oct 15, 2024
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
68f1131
make edits to description
sguequierre e360ec4
Apply suggestions from code review
sguequierre 0d11af1
Update client.py
sguequierre 4198d6c
Update client.py
sguequierre cafd6dd
Apply suggestions from code review
sguequierre 8f25935
Apply suggestions from code review
sguequierre f3f37c2
Apply suggestions from code review
sguequierre b56973d
Apply suggestions from code review
sguequierre 40dcb53
Update client.py
sguequierre 817d0b1
Apply suggestions from code review
sguequierre c19134b
shorten line
sguequierre de4fbde
fix code sample
sguequierre c5496c7
Apply suggestions from code review
sguequierre 8bec66a
Merge remote-tracking branch 'upstream/main' into DOCS-2902/machine-m…
sguequierre 37c86f0
Update src/viam/robot/client.py
npentrel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
subtype
, you could doCamera.SUBTYPE.resource_subtype
which is a bit more verbose but fully typechecked.This way also works, but just in case people don't know how to get the subtype? Up to y'all, just showing an additional way of doing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way seems more straightforward but thank you