-
Notifications
You must be signed in to change notification settings - Fork 56
RSDK-6169 - gRPC debugging client api #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dgottlieb fyi |
This makes sense to me, thanks for linking the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of skimmed over the components/services since the changes seemed straightforward. Thank you for the flyby change!
@njooma not sure if you wanted to look at it particularly, but just fyi since we had that discussion about possible implementations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
Adds the gRPC debugging client api.
Note to reviewers: a lot of this is pretty boilerplate. I certainly won't complain if you look at all of it but I think the main places to focus are
rpc_client_base.py
andutils.py
Flyby: refactors
dict_to_struct
to make the obj argument type optional, such that we don't need to haveif extra is None: extra = {}
in every method.Example code:
example logs: