RSDK-6169 - gRPC debugging client api#747
Merged
stuqdog merged 6 commits intoviamrobotics:mainfrom Oct 1, 2024
Merged
Conversation
Member
Author
|
@dgottlieb fyi |
Member
|
This makes sense to me, thanks for linking the PR! |
Member
purplenicole730
left a comment
There was a problem hiding this comment.
Kind of skimmed over the components/services since the changes seemed straightforward. Thank you for the flyby change!
purplenicole730
approved these changes
Sep 26, 2024
Member
Author
|
@njooma not sure if you wanted to look at it particularly, but just fyi since we had that discussion about possible implementations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the gRPC debugging client api.
Note to reviewers: a lot of this is pretty boilerplate. I certainly won't complain if you look at all of it but I think the main places to focus are
rpc_client_base.pyandutils.pyFlyby: refactors
dict_to_structto make the obj argument type optional, such that we don't need to haveif extra is None: extra = {}in every method.Example code:
example logs: