Skip to content

RSDK-8506-RSDK-8253: fix docs #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

purplenicole730
Copy link
Member

@purplenicole730 purplenicole730 commented Aug 15, 2024

Data Jira ticket
Vision Jira ticket

BREAKING CHANGE for anyone using tabular_data_capture_upload with positional arguments.
Apparently the function fails without the request times, so presumably there's no one successfully calling it without this argument.

Changes:

  • data_request_times is no longer optional
  • comment changes for data_request_times and component_type
  • comment changes for get_classifications and get_detections

New docs for tabular_data_capture_upload:
image
image

@purplenicole730 purplenicole730 marked this pull request as ready for review August 15, 2024 16:58
@purplenicole730 purplenicole730 requested a review from a team as a code owner August 15, 2024 16:58
@purplenicole730 purplenicole730 changed the title RSDK-8506: fix tabular data capture upload docs RSDK-8506-RSDK-8253: fix tabular data capture upload docs Aug 15, 2024
@purplenicole730 purplenicole730 changed the title RSDK-8506-RSDK-8253: fix tabular data capture upload docs RSDK-8506-RSDK-8253: fix docs Aug 15, 2024
@purplenicole730 purplenicole730 merged commit 79a4528 into viamrobotics:main Aug 16, 2024
12 checks passed
@purplenicole730 purplenicole730 deleted the RSDK-8506-fix-tabular-data-capture-upload-docs branch August 16, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants