-
Notifications
You must be signed in to change notification settings - Fork 56
RSDK-8440: fix license finder #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-8440: fix license finder #706
Conversation
.github/workflows/license_finder.yml
Outdated
|
||
- name: Run license finder | ||
run: | | ||
poetry run license_finder --python-version=3 | ||
/opt/hostedtoolcache/Ruby/*/x64/lib/ruby/gems/*/gems/license_finder-*/bin/license_finder_pip.py requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to invoke this via python3
. It looks like in the failed jobs it's python3 /path/to/license_finder_pip.py /path/to/requirements.txt
, and in successful runs in other SDKs the output is different from here (it should say All dependencies are approved for use
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right about the expected output! Using python3 was not the method since the problem was the script itself, so I fixed it. Thanks for catching that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good and the license_finder check succeeds 🎉
Based on the available logs, this workflow has been failing for at least 3 months. Before that, the git logs have been removed, so we're not sure when the failure started.
license_finder
has some issues with Python version 3.12, so now the workflow is using 3.11.5.In the workflow, the command to run
license_finder
was changed so that errors fail the workflow instead of letting it succeed.Things I tried that didn't work, wasn't the best solution, or introduced more errors:
pip install six
doesn't change anythingpip install pip==22.0
introduces another errorpip install pip==23.0
introduces another errorpip install pip==20.0.2
introduces another errorpip install pip==9.0.0
introduces another errorcurl -sS https://bootstrap.pypa.io/get-pip.py | python3
doesn't change anythingpython version 3.11
doesn't change anythingpip install pyenv
doesn't change anything/opt/hostedtoolcache/Ruby/*/x64/lib/ruby/gems/*/gems/license_finder-*/bin/license_finder_pip.py requirements.txt
doesn't actually run license_finderpoetry run license_finder --python-version=3
fails even after using python v3.11.5poetry run license_finder
fails even after using python v3.11.5