Skip to content

Add MachineStatus to Robot API #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

ale7714
Copy link
Member

@ale7714 ale7714 commented Aug 7, 2024

@ale7714 ale7714 requested a review from a team as a code owner August 7, 2024 20:15
@ale7714 ale7714 requested review from stuqdog and lia-viam August 7, 2024 20:15
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing (no need to re-request review from me) otherwise LGTM!


::

machine_status = machine.get_machine_status()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we're missing an await here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch ty!

@ale7714 ale7714 merged commit 6984e42 into viamrobotics:main Aug 8, 2024
12 checks passed
@ale7714 ale7714 deleted the machinestatus branch August 8, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants