Skip to content

Remove duplication #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

Remove duplication #699

merged 1 commit into from
Aug 1, 2024

Conversation

npentrel
Copy link
Contributor

@npentrel npentrel commented Jul 31, 2024 •
edited
Loading

Can leave as is if this was intended but the duplication seems odd to me

@npentrel npentrel requested a review from a team as a code owner July 31, 2024 11:12
@npentrel npentrel requested review from stuqdog and lia-viam July 31, 2024 11:12
stuqdog
stuqdog reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me but I don't know if there's a particular reason if we had it the way we did before, I'd want to get @njooma's perspective on this.

njooma
njooma approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just there as a way to make sure people didn't miss it

@npentrel npentrel merged commit 2ceb087 into viamrobotics:main Aug 1, 2024
12 checks passed
@npentrel npentrel deleted the deprecated-methods branch August 5, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma approved these changes

@stuqdog stuqdog stuqdog approved these changes

@lia-viam lia-viam Awaiting requested review from lia-viam lia-viam is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npentrel @njooma @stuqdog