Skip to content

Update get_status signature #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 2, 2024
Merged

Update get_status signature #698

merged 8 commits into from
Aug 2, 2024

Conversation

npentrel
Copy link
Contributor

@npentrel npentrel commented Jul 31, 2024 •
edited
Loading

not quite sure how to fix the errors

@npentrel npentrel requested a review from a team as a code owner July 31, 2024 11:03
npentrel
npentrel commented Jul 31, 2024
View reviewed changes
npentrel
npentrel commented Jul 31, 2024
View reviewed changes
npentrel
npentrel commented Jul 31, 2024
View reviewed changes
@njooma
Copy link
Member

njooma commented Aug 1, 2024

I fixed the issue -- there was a naming collision when you imported Status -- we were already importing another field named Status

@npentrel npentrel merged commit b5ba049 into main Aug 2, 2024
12 checks passed
@npentrel npentrel deleted the npentrel-patch-1 branch August 2, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma approved these changes

@purplenicole730 purplenicole730 Awaiting requested review from purplenicole730 purplenicole730 is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npentrel @njooma