RSDK-7189: add data wrappers #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
approved these changes
May 2, 2024
Comment on lines
+923
to
+924
| self.organization_id = request.organization_id | ||
| self.password = request.password |
There was a problem hiding this comment.
We assign these values here but never do anything with them (same for organization_id and {s|m}ql_query below). If we want to keep these around we should probably test that they're properly set in the appropriate tests. That said, typically I think of these kinds of tests (confirming a value has been set on the class object) being important for methods that don't otherwise return anything, which isn't the case here. So probably it's easiest to just get rid of these entirely.
njooma
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.