RSDK-7436: remove analog and digital statuses from python sdk #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martha-johnston
force-pushed
the
rsdk-7436
branch
from
d735fcb to
6c87058
Compare
purplenicole730
approved these changes
Apr 29, 2024
|
hmm did not expect so many conflicts in the proto files... would it be easier for me to revert that commit and pull in the other automated PR that builds the protos? |
|
@martha-johnston pull from main and then rerun |
martha-johnston
force-pushed
the
rsdk-7436
branch
from
6de364f to
aa09820
Compare
@purplenicole730 lmk when you look over it again! |
njooma
reviewed
Apr 30, 2024
| @@ -19,12 +18,12 @@ async def create_status(component: Board) -> Status: | |||
| for x in analog_names: | |||
| analog = await component.analog_reader_by_name(x) | |||
| read = await analog.read() | |||
| analogs[x] = AnalogStatus(value=read) | |||
| analogs[x] = int(read) | |||
There was a problem hiding this comment.
Do you need this int conversion?
There was a problem hiding this comment.
I guess not just removed it
njooma
approved these changes
Apr 30, 2024
purplenicole730
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.